The i3 FAQ has migrated to All content here is read-only.
Ask Your Question

Why is $patch not merged and made optional?

asked 2012-11-20 10:54:37 +0000

Michael gravatar image

Sometimes, there are patches on the mailing list (or elsewhere) which are not merged into i3. Why can’t we have them optionally?

Here is an example:

edit retag flag offensive close merge delete

1 answer

Sort by » oldest newest most voted

answered 2012-11-20 11:01:19 +0000

Michael gravatar image

There are many downsides to letting software grow without any bounds (that is, merging all patches that come up):

  • More options means longer documentation and more choice for users. While choice is not always bad, the amount of options we have can already be overwhelming. I’d rather have users read all the documentation because it’s short than providing so many options that people cannot manage to read the docs anymore, but two people are happy with their edge cases.
  • More code paths means more things to test, both automated (where appropriate) and manually. This means more effort for all our developers, which is a bad thing. As an example, I am running i3 with xft fonts on my notebook and with x core fonts on my workstation, just to make sure that both code paths are working fine.
  • The more different use cases we support, the less clear it becomes what i3 actually is and how it is intended to use. Eventually, it will be able to receive email ;-).

I hope that makes my intentions clear when declining to merge patches. I do see that people obviously put effort into their work and obviously have a use-case for it, but because of the above reasons I think it’s better to not merge some patches.

edit flag offensive delete link more


why not making plugin system so everybody could be happy ?

majkinetor gravatar imagemajkinetor ( 2013-06-26 23:27:13 +0000 )edit

A plugin system is _a lot_ of effort to write and maintain, because it allows people to touch all the corner cases that are not well tested currently. All the reasons I stated in the answer do apply (maybe even stronger) to a plugin system.

Michael gravatar imageMichael ( 2013-06-29 17:41:54 +0000 )edit

Question Tools


Asked: 2012-11-20 10:54:37 +0000

Seen: 1,107 times

Last updated: Nov 20 '12